Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-9787] Allow passing Decimal as input for ColumnIntHWM #58

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Dec 5, 2023

Change Summary

Allow to pass Decimal and float input for ColumnIntHWM, but only if value does contain only 0 after decimal point - 1.000 is valid, 1.002 is not.

This allows to drop custom DecimalHWM class from onETL.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus force-pushed the feature/DOP-9787-column-int-allow-decimal branch from 14edaec to acfc6d7 Compare December 5, 2023 10:34
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a44f44) 95.56% compared to head (822cae5) 95.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #58      +/-   ##
===========================================
+ Coverage    95.56%   95.62%   +0.06%     
===========================================
  Files           48       48              
  Lines         1060     1075      +15     
  Branches       181      185       +4     
===========================================
+ Hits          1013     1028      +15     
  Misses          27       27              
  Partials        20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit 09857be into develop Dec 5, 2023
14 checks passed
@dolfinus dolfinus deleted the feature/DOP-9787-column-int-allow-decimal branch December 5, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants