Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-11304] Make directory field in FileHWM optional #60

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Dec 6, 2023

Change Summary

  1. Make FileHWM.directory field optional. Update related tests.
  2. Changed type if items in FileListHWM.value from RelativePath to AbsolutePath, to avoid storing different path types with and without directory specified. Validation that paths in .value should be consistent with directory is still here, it is just disabled then directory=None. Method get_absolute_paths was dropped.
  3. Add missing method OldFileListHWM.as_new_hwm() and add related tests.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d2d720c) 95.60% compared to head (43c37c2) 95.40%.

Files Patch % Lines
etl_entities/hwm/file/file_list_hwm.py 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #60      +/-   ##
===========================================
- Coverage    95.60%   95.40%   -0.20%     
===========================================
  Files           48       48              
  Lines         1069     1067       -2     
  Branches       184      186       +2     
===========================================
- Hits          1022     1018       -4     
- Misses          27       28       +1     
- Partials        20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit f839db0 into develop Dec 7, 2023
13 of 14 checks passed
@dolfinus dolfinus deleted the feature/DOP-11304 branch December 7, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants