Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-11342] - update GenericPath to use with python 3.12 #62

Merged
merged 4 commits into from
Dec 8, 2023
Merged

[DOP-11342] - update GenericPath to use with python 3.12 #62

merged 4 commits into from
Dec 8, 2023

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Dec 8, 2023 •
edited

Change Summary

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Dec 8, 2023
@maxim-lixakov maxim-lixakov self-assigned this Dec 8, 2023
dolfinus
dolfinus reviewed Dec 8, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b720512) 96.24% compared to head (e12527f) 96.28%.

Files Patch % Lines
etl_entities/instance/path/relative_path.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #62      +/-   ##
===========================================
+ Coverage    96.24%   96.28%   +0.03%     
===========================================
  Files           48       48              
  Lines         1039     1049      +10     
  Branches       178      183       +5     
===========================================
+ Hits          1000     1010      +10     
  Misses          23       23              
  Partials        16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov removed the ci:skip-changelog Add this label to skip changelog file check label Dec 8, 2023
@maxim-lixakov maxim-lixakov marked this pull request as ready for review December 8, 2023 11:46
@dolfinus dolfinus merged commit 5fe1fd7 into develop Dec 8, 2023
13 of 15 checks passed
@dolfinus dolfinus deleted the feature/DOP-11342 branch December 8, 2023 14:56
@dolfinus dolfinus mentioned this pull request Dec 12, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfinus dolfinus dolfinus approved these changes

@dmitry-pedchenko dmitry-pedchenko Awaiting requested review from dmitry-pedchenko

Assignees

@maxim-lixakov maxim-lixakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxim-lixakov @dolfinus