Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-7900] Add negative tests on SparkS3.check #100

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Aug 3, 2023

Change Summary

After adding negative test for SparkS3.check() I've found that it does not fail even if user passed wrong host or credentials. Fixed.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Aug 3, 2023
@dolfinus dolfinus temporarily deployed to test-pypi August 3, 2023 13:13 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 3, 2023 13:23 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #100 (df85564) into develop (2df229b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #100      +/-   ##
===========================================
+ Coverage    93.57%   93.60%   +0.02%     
===========================================
  Files          168      168              
  Lines         7177     7177              
  Branches      1369     1369              
===========================================
+ Hits          6716     6718       +2     
+ Misses         335      333       -2     
  Partials       126      126              
Files Changed Coverage Δ
...nnection/file_df_connection/spark_s3/connection.py 92.30% <100.00%> (+1.39%) ⬆️

@dolfinus dolfinus self-assigned this Aug 3, 2023
@dolfinus dolfinus marked this pull request as ready for review August 3, 2023 13:37
@dolfinus dolfinus temporarily deployed to test-pypi August 3, 2023 14:28 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 3, 2023 14:47 — with GitHub Actions Inactive
@dolfinus dolfinus merged commit 2d50c57 into develop Aug 7, 2023
33 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-7900 branch August 7, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants