-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-7957] Rename mode -> if_exists, and make modes more descriptive #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 14:31
e34ab7c
to
0929db9
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 14:34
0929db9
to
89f3f9e
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 14:35
89f3f9e
to
626313f
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 15:14
626313f
to
c5bbe00
Compare
Codecov Report
@@ Coverage Diff @@
## develop #108 +/- ##
===========================================
+ Coverage 93.72% 93.87% +0.15%
===========================================
Files 169 169
Lines 7285 7352 +67
Branches 1404 1428 +24
===========================================
+ Hits 6828 6902 +74
+ Misses 332 328 -4
+ Partials 125 122 -3
|
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 15:38
c5bbe00
to
f645725
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 15:39
f645725
to
db0fb3f
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 15:42
db0fb3f
to
728010b
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 15:45
728010b
to
1778e1e
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 8, 2023 15:57
1778e1e
to
e1f2ac1
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 09:37
e1f2ac1
to
ec2e5f7
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 09:39
ec2e5f7
to
669be1f
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 09:55
669be1f
to
add1c19
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 09:57
add1c19
to
8b263fd
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 09:59
8b263fd
to
520f319
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
2 times, most recently
from
August 9, 2023 10:36
0473293
to
e4205ce
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 10:42
e4205ce
to
af2b306
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 13:05
af2b306
to
c2f2f74
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 13:09
c2f2f74
to
2f355a8
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 9, 2023 13:15
2f355a8
to
6b023e2
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 10, 2023 08:15
6b023e2
to
1a759f1
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 10, 2023 08:23
1a759f1
to
63cf9d8
Compare
maxim-lixakov
approved these changes
Aug 10, 2023
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 11, 2023 08:19
63cf9d8
to
cdf3c02
Compare
dolfinus
force-pushed
the
feature/DOP-7957
branch
from
August 11, 2023 09:29
cdf3c02
to
63eedf0
Compare
andy-takker
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
mode
->if_exists
. New name should be more descriptive than old one, even if it is different from Spark naming.overwrite
andoverwrite_table
toreplace_entire_table
. For MongoDB it isreplace_entire_collection
.overwrite_partitions
->replace_overlapping_partitions
(to matchFileWriter.Options.if_exists
)overwrite
->replace_file
(should be more descriptive)delete_all
->replace_entire_directory
(for consistent naming with other classes, also more desciptive)partitionBy
, or vice versa.WriteOptions
attributes documentation to matchFileWriter.Options
(for Spark they its just the same options).Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)