Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-7986] Add Kafka.ScramAuth #115

Merged
merged 1 commit into from
Aug 14, 2023
Merged

[DOP-7986] Add Kafka.ScramAuth #115

merged 1 commit into from
Aug 14, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Aug 11, 2023

Change Summary

  • Added Kafka.ScramAuth class
  • Added related tests & documentation
  • Added healthcheck for CI containers

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Aug 11, 2023
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 13:45 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:03 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:15 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:19 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:27 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:39 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:40 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:41 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:45 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 14:53 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 15:00 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 11, 2023 15:05 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #115 (9e0783f) into develop (7ecc684) will increase coverage by 0.03%.
The diff coverage is 96.00%.

@@             Coverage Diff             @@
##           develop     #115      +/-   ##
===========================================
+ Coverage    93.97%   94.00%   +0.03%     
===========================================
  Files          170      171       +1     
  Lines         7403     7428      +25     
  Branches      1436     1437       +1     
===========================================
+ Hits          6957     6983      +26     
  Misses         323      323              
+ Partials       123      122       -1     
Files Changed Coverage Δ
...connection/db_connection/kafka/kafka_scram_auth.py 95.65% <95.65%> (ø)
onetl/connection/db_connection/kafka/connection.py 98.91% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@dolfinus dolfinus marked this pull request as ready for review August 11, 2023 15:20
@Neustradamus
Copy link

@dolfinus: Nice :)

Linked to:

@dolfinus dolfinus self-assigned this Aug 14, 2023
@dolfinus dolfinus merged commit 914751f into develop Aug 14, 2023
49 checks passed
@dolfinus dolfinus deleted the feature/DOP-7986 branch August 14, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants