Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-8133] Rename disable_clients_logging to setup_clients_logging #120

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Aug 14, 2023

Change Summary

  • Rename disable_clients_logging to setup_clients_logging. This is a breaking change, but almost nobody calls this function explicitly, so not adding a wrapper with old name.
  • Add level argument to new function. This allows to change logging level of underlying modules if user need. But Py4J log level is handled separately, just to avoid generating so many logs they become unreadable.
  • Added enable_clients argument to setup_logging. For debug purposes it is recommended to be True
  • Update module names list, it is outdated.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Aug 14, 2023
@dolfinus dolfinus temporarily deployed to test-pypi August 14, 2023 15:58 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 14, 2023 16:09 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #120 (42ed3ac) into develop (ad01aea) will decrease coverage by 0.04%.
The diff coverage is 44.44%.

@@             Coverage Diff             @@
##           develop     #120      +/-   ##
===========================================
- Coverage    94.10%   94.06%   -0.04%     
===========================================
  Files          172      172              
  Lines         7484     7487       +3     
  Branches      1439     1440       +1     
===========================================
  Hits          7043     7043              
- Misses         321      324       +3     
  Partials       120      120              
Files Changed Coverage Δ
onetl/log.py 80.89% <44.44%> (-2.83%) ⬇️

@dolfinus dolfinus temporarily deployed to test-pypi August 15, 2023 08:28 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 15, 2023 09:02 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 15, 2023 09:20 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 15, 2023 09:23 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 15, 2023 16:19 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi August 16, 2023 08:39 — with GitHub Actions Inactive
@dolfinus dolfinus marked this pull request as ready for review August 16, 2023 08:47
@dolfinus dolfinus merged commit 36432c0 into develop Aug 16, 2023
32 of 33 checks passed
@dolfinus dolfinus deleted the feature/DOP-8133 branch August 16, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants