-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-8133] Rename disable_clients_logging to setup_clients_logging #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-8133
branch
from
August 14, 2023 15:58
6f7b5b3
to
395f92e
Compare
dolfinus
force-pushed
the
feature/DOP-8133
branch
from
August 14, 2023 16:09
395f92e
to
ed67f60
Compare
Codecov Report
@@ Coverage Diff @@
## develop #120 +/- ##
===========================================
- Coverage 94.10% 94.06% -0.04%
===========================================
Files 172 172
Lines 7484 7487 +3
Branches 1439 1440 +1
===========================================
Hits 7043 7043
- Misses 321 324 +3
Partials 120 120
|
dolfinus
force-pushed
the
feature/DOP-8133
branch
from
August 15, 2023 08:28
ed67f60
to
ce341e1
Compare
dolfinus
force-pushed
the
feature/DOP-8133
branch
from
August 15, 2023 09:02
ce341e1
to
72da57a
Compare
dolfinus
force-pushed
the
feature/DOP-8133
branch
from
August 15, 2023 09:20
72da57a
to
7123644
Compare
dolfinus
force-pushed
the
feature/DOP-8133
branch
from
August 15, 2023 09:23
7123644
to
140f435
Compare
dolfinus
force-pushed
the
feature/DOP-8133
branch
from
August 15, 2023 16:19
140f435
to
a7b8000
Compare
dolfinus
force-pushed
the
feature/DOP-8133
branch
from
August 16, 2023 08:39
a7b8000
to
42ed3ac
Compare
maxim-lixakov
approved these changes
Aug 16, 2023
andy-takker
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
disable_clients_logging
tosetup_clients_logging
. This is a breaking change, but almost nobody calls this function explicitly, so not adding a wrapper with old name.level
argument to new function. This allows to change logging level of underlying modules if user need. But Py4J log level is handled separately, just to avoid generating so many logs they become unreadable.enable_clients
argument tosetup_logging
. For debug purposes it is recommended to beTrue
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)