-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-8140] Split Clickhouse and Clickhouse.Dialect to separated submodules #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 08:43
df9d127
to
7eb02e9
Compare
dolfinus
changed the title
[DOP-8140] Split Clickhouse and Clickhouse.Dialect to separated submo…
[DOP-8140] Split Clickhouse and Clickhouse.Dialect to separated submodules
Aug 21, 2023
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 09:08
4b7a97f
to
1980642
Compare
Codecov Report
@@ Coverage Diff @@
## develop #133 +/- ##
===========================================
+ Coverage 94.22% 94.29% +0.07%
===========================================
Files 195 207 +12
Lines 7684 7697 +13
Branches 1450 1451 +1
===========================================
+ Hits 7240 7258 +18
+ Misses 324 320 -4
+ Partials 120 119 -1
|
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 09:43
1980642
to
d5d7385
Compare
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 10:00
d5d7385
to
d9bc06c
Compare
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 10:07
d9bc06c
to
35339f8
Compare
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 10:45
35339f8
to
444bdd0
Compare
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 10:52
444bdd0
to
150319f
Compare
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 11:25
150319f
to
04832cf
Compare
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 11:39
04832cf
to
c5479c5
Compare
dolfinus
removed
the
ci:skip-changelog
Add this label to skip changelog file check
label
Aug 21, 2023
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 21, 2023 11:49
c5479c5
to
8f59bb8
Compare
dmitry-pedchenko
approved these changes
Aug 22, 2023
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 22, 2023 15:40
8f59bb8
to
3201471
Compare
andy-takker
approved these changes
Aug 23, 2023
dolfinus
force-pushed
the
improvement/DOP-8140-clickhouse
branch
from
August 30, 2023 07:48
3201471
to
721d804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Clickhouse
andClickhouse.Dialect
to submodules. Same forMSSQL
,MySQL
,Oracle
,Postgres
,Teradata
.partitioningMode="hash"
and"mod"
fromReadOptions
toDialect
. Because of this, connection-related classesReadOptions
andOptions
are not required anymore, all JDBC connection uses the sameJDBCOptions
andJDBCLegacyOptions
.DBReader
and.sql
withJDBCReadOptions
)DBWriter
withJDBCWriteOptions
).fetch
and.execute
withJDBCOptions
)partitioningMode="range"
with unsetlowerBound
/upperBound
, discovered and fixed bug in Oracle dialect - expressionMAX(column) AS max
was returned as dataframe column with nameMAX
instead ofmax
.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)