[DOP-8511] Allow to pass Kafka topic name in format 'some.topic.name' #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Previously, all source and target names should be match format
name
orschema.name
, but notschema.some.name
- it was impossible to determine which part is schema and which is actual source name. But Kafka topics may have almost any name possible, so this caused confusion. MongoDB collection names can also have dots in names.Now Table object in etl-entities does not have
db
field at all, so name is checked explicitly inConnection.Dialect
. Update onETL accordingly - RDBMS table names still should match formatschema.name
, but Kafka and MongoDB don't have such restrictions.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)