Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-8511] Allow to pass Kafka topic name in format 'some.topic.name' #139

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Sep 4, 2023

Change Summary

Previously, all source and target names should be match format name or schema.name, but not schema.some.name - it was impossible to determine which part is schema and which is actual source name. But Kafka topics may have almost any name possible, so this caused confusion. MongoDB collection names can also have dots in names.

Now Table object in etl-entities does not have db field at all, so name is checked explicitly in Connection.Dialect. Update onETL accordingly - RDBMS table names still should match format schema.name, but Kafka and MongoDB don't have such restrictions.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #139 (66b6f25) into develop (1d6e0a4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #139      +/-   ##
===========================================
- Coverage    94.29%   94.29%   -0.01%     
===========================================
  Files          207      207              
  Lines         7697     7695       -2     
  Branches      1451     1450       -1     
===========================================
- Hits          7258     7256       -2     
  Misses         320      320              
  Partials       119      119              
Files Changed Coverage Δ
...netl/connection/db_connection/greenplum/dialect.py 100.00% <ø> (ø)
onetl/connection/db_connection/hive/dialect.py 85.71% <ø> (ø)
...onnection/db_connection/jdbc_connection/dialect.py 100.00% <ø> (ø)
onetl/connection/db_connection/kafka/dialect.py 91.30% <ø> (ø)
onetl/connection/db_connection/mongodb/dialect.py 100.00% <ø> (ø)
...onnection/db_connection/dialect_mixins/__init__.py 100.00% <100.00%> (ø)
...n/db_connection/dialect_mixins/support_name_any.py 100.00% <100.00%> (ø)
...on/dialect_mixins/support_name_with_schema_only.py 100.00% <100.00%> (ø)

@dolfinus dolfinus marked this pull request as ready for review September 4, 2023 13:19
@dolfinus dolfinus merged commit 0c55572 into develop Sep 5, 2023
49 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-8511-1 branch September 5, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants