Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-8528] Allow modes "ignore" and "error" in GreenplumWriteOptions #142

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Sep 5, 2023

Change Summary

  • add ignore and error modes (if_exists=...) to Greenplum.WriteOptions
  • add unit and integration tests
  • updated documentation

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Sep 5, 2023
@maxim-lixakov maxim-lixakov self-assigned this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #142 (1a7f2b7) into develop (ebbeed2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #142   +/-   ##
========================================
  Coverage    94.29%   94.29%           
========================================
  Files          207      207           
  Lines         7697     7699    +2     
  Branches      1451     1451           
========================================
+ Hits          7258     7260    +2     
  Misses         320      320           
  Partials       119      119           
Files Changed Coverage Δ
...l/connection/db_connection/greenplum/connection.py 70.38% <100.00%> (ø)
...netl/connection/db_connection/greenplum/options.py 100.00% <100.00%> (ø)

@maxim-lixakov maxim-lixakov marked this pull request as ready for review September 5, 2023 10:57
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 5, 2023 11:43 — with GitHub Actions Inactive
@dolfinus
Copy link
Member

dolfinus commented Sep 5, 2023

Добавь запись в docs/changelog/next_release, по аналогии с существующими там файлами

@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 5, 2023 14:15 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov removed the ci:skip-changelog Add this label to skip changelog file check label Sep 5, 2023
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 5, 2023 14:19 — with GitHub Actions Inactive
@dolfinus dolfinus changed the title [DOP-8528] - update modes in GreenplumWriteOptions [DOP-8528] Allow modes "ignore" and "error" in GreenplumWriteOptions Sep 5, 2023
@maxim-lixakov maxim-lixakov merged commit 2117f92 into develop Sep 6, 2023
33 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-8528 branch September 6, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants