-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-8959] Add Excel file format support #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 12:25
6538bcd
to
7c9b1be
Compare
Codecov Report
@@ Coverage Diff @@
## develop #148 +/- ##
===========================================
+ Coverage 94.29% 94.32% +0.03%
===========================================
Files 207 208 +1
Lines 7727 7775 +48
Branches 1455 1465 +10
===========================================
+ Hits 7286 7334 +48
Misses 321 321
Partials 120 120
|
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 12:44
7c9b1be
to
aa89aa1
Compare
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 12:57
aa89aa1
to
10d344d
Compare
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 12:58
10d344d
to
8bee7b6
Compare
dolfinus
requested review from
andy-takker,
dmitry-pedchenko and
maxim-lixakov
September 18, 2023 12:59
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 13:12
8bee7b6
to
81ec2e3
Compare
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 13:30
81ec2e3
to
7054bc9
Compare
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 13:34
7054bc9
to
73cdeaa
Compare
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 13:35
73cdeaa
to
a0dc164
Compare
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 18, 2023 13:44
a0dc164
to
7b301fd
Compare
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 19, 2023 07:51
7b301fd
to
f2f17f3
Compare
dolfinus
force-pushed
the
feature/DOP-8959
branch
from
September 19, 2023 07:51
f2f17f3
to
9dd3f8d
Compare
andy-takker
approved these changes
Sep 20, 2023
maxim-lixakov
approved these changes
Sep 20, 2023
dmitry-pedchenko
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Excel
file format, based on https://github.com/crealytics/spark-excel. Supports only Spark 3.2+. Can read both.xlsx
and.xls
files, but write only.xlsx
.Excel.get_packages()
method also haspackage_version
attribute, which should be chosen according to Spark version used.Documentation: https://onetl--148.org.readthedocs.build/en/148/file_df/file_formats/excel.html
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)