Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-8959] Add Excel file format support #148

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Sep 18, 2023

Change Summary

  • Added Excel file format, based on https://github.com/crealytics/spark-excel. Supports only Spark 3.2+. Can read both .xlsx and .xls files, but write only .xlsx.
  • Not all Spark versions are present in Maven index for this package, e.g. Spark 3.2.4 support was added in package version 0.19, but Spark 3.2.3 was supported only in 0.18.6/0.18.7. Because of this, Excel.get_packages() method also has package_version attribute, which should be chosen according to Spark version used.
  • Because of previous item, Spark 3.2.3 in CI build matrix was replaced with 3.2.4

Documentation: https://onetl--148.org.readthedocs.build/en/148/file_df/file_formats/excel.html

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus temporarily deployed to test-pypi September 18, 2023 12:25 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #148 (9dd3f8d) into develop (2caf72b) will increase coverage by 0.03%.
The diff coverage is 95.83%.

@@             Coverage Diff             @@
##           develop     #148      +/-   ##
===========================================
+ Coverage    94.29%   94.32%   +0.03%     
===========================================
  Files          207      208       +1     
  Lines         7727     7775      +48     
  Branches      1455     1465      +10     
===========================================
+ Hits          7286     7334      +48     
  Misses         321      321              
  Partials       120      120              
Files Changed Coverage Δ
onetl/connection/db_connection/kafka/connection.py 98.98% <ø> (+1.01%) ⬆️
...etl/connection/db_connection/mongodb/connection.py 93.75% <ø> (ø)
...nnection/file_df_connection/spark_s3/connection.py 92.56% <ø> (ø)
onetl/file/format/avro.py 95.31% <ø> (ø)
onetl/file/format/excel.py 95.74% <95.74%> (ø)
onetl/file/format/__init__.py 100.00% <100.00%> (ø)

@dolfinus dolfinus temporarily deployed to test-pypi September 18, 2023 12:44 — with GitHub Actions Inactive
@dolfinus dolfinus self-assigned this Sep 18, 2023
@dolfinus dolfinus temporarily deployed to test-pypi September 18, 2023 12:57 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 18, 2023 12:58 — with GitHub Actions Inactive
@dolfinus dolfinus marked this pull request as ready for review September 18, 2023 12:59
@dolfinus dolfinus temporarily deployed to test-pypi September 18, 2023 13:12 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 18, 2023 13:30 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 18, 2023 13:35 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 18, 2023 13:44 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 19, 2023 07:52 — with GitHub Actions Inactive
@dolfinus dolfinus merged commit 982d96c into develop Sep 20, 2023
38 checks passed
@dolfinus dolfinus deleted the feature/DOP-8959 branch September 20, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants