Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-8837] - add Samba file_connection class #150

Merged
merged 16 commits into from
Sep 20, 2023
Merged

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Sep 19, 2023

Change Summary

  • add Samba file connection class
  • add unit and integration tests
  • add samba container, .env.* files, fixtures

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Sep 19, 2023
@maxim-lixakov maxim-lixakov self-assigned this Sep 19, 2023
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 19, 2023 09:31 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #150 (51edbc1) into develop (982d96c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #150   +/-   ##
========================================
  Coverage    94.32%   94.32%           
========================================
  Files          208      208           
  Lines         7775     7775           
  Branches      1465     1465           
========================================
  Hits          7334     7334           
  Misses         321      321           
  Partials       120      120           
Files Changed Coverage Δ
conftest.py 100.00% <ø> (ø)
onetl/connection/__init__.py 90.00% <ø> (ø)

.env.local Outdated Show resolved Hide resolved
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 19, 2023 14:01 — with GitHub Actions Inactive
@dolfinus dolfinus marked this pull request as ready for review September 19, 2023 14:03
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 19, 2023 20:12 — with GitHub Actions Inactive
docker-compose.yml Outdated Show resolved Hide resolved
.env.local Show resolved Hide resolved
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 20, 2023 10:19 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 20, 2023 10:27 — with GitHub Actions Inactive
.env.docker Outdated Show resolved Hide resolved
Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 20, 2023 10:31 — with GitHub Actions Inactive
@dolfinus dolfinus self-requested a review September 20, 2023 10:31
@maxim-lixakov maxim-lixakov merged commit 252ce9a into develop Sep 20, 2023
50 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-8837 branch September 20, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants