Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-9085] Improve Greenplum documentation #154

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Sep 25, 2023

Change Summary

Drastically improve Greenplum documentation:

  • Added information about network ports, grants, pg_hba.conf and so on.
  • Added interaction schemas for reading, writing and executing statements in Greenplum, using PlantUML.
  • Added recommendations about reading data from views and JOIN results from Greenplum.
  • Removed upper version limit from Sphinx

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Sep 25, 2023
@dolfinus dolfinus temporarily deployed to test-pypi September 25, 2023 11:27 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #154 (1f82680) into develop (b8bd6dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #154   +/-   ##
========================================
  Coverage    94.24%   94.24%           
========================================
  Files          209      209           
  Lines         7910     7910           
  Branches      1483     1483           
========================================
  Hits          7455     7455           
  Misses         332      332           
  Partials       123      123           
Files Coverage Δ
...l/connection/db_connection/greenplum/connection.py 70.38% <ø> (ø)
...netl/connection/db_connection/greenplum/options.py 100.00% <ø> (ø)
...nnection/file_df_connection/spark_s3/connection.py 92.56% <ø> (ø)

@dolfinus dolfinus temporarily deployed to test-pypi September 25, 2023 11:44 — with GitHub Actions Inactive
@dolfinus dolfinus marked this pull request as ready for review September 25, 2023 11:45
@dolfinus dolfinus temporarily deployed to test-pypi September 25, 2023 13:45 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 25, 2023 14:58 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 26, 2023 10:11 — with GitHub Actions Inactive
@dolfinus dolfinus merged commit ae6bde6 into develop Sep 26, 2023
36 checks passed
@dolfinus dolfinus deleted the improvement/DOP-9085 branch September 26, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants