-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-11906] Improve Clickhouse documentation #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ad0dfa
to
9bdc85c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #211 +/- ##
===========================================
+ Coverage 94.11% 94.12% +0.01%
===========================================
Files 204 204
Lines 7836 7836
Branches 1399 1399
===========================================
+ Hits 7375 7376 +1
+ Misses 336 335 -1
Partials 125 125 ☔ View full report in Codecov by Sentry. |
9bdc85c
to
9f7224f
Compare
9f7224f
to
f9a03b2
Compare
f9a03b2
to
77c05a0
Compare
77c05a0
to
8fb3099
Compare
8fb3099
to
79dd7db
Compare
79dd7db
to
a249c00
Compare
a249c00
to
f95352b
Compare
7ad1b36
to
f95352b
Compare
f95352b
to
a3622d8
Compare
a3622d8
to
2c09d26
Compare
2c09d26
to
c82ea62
Compare
c82ea62
to
05cde02
Compare
05cde02
to
a0fab9b
Compare
a0fab9b
to
708e3b0
Compare
708e3b0
to
84cbd01
Compare
84cbd01
to
378f5f6
Compare
378f5f6
to
20ec9a6
Compare
20ec9a6
to
1670a03
Compare
maxim-lixakov
approved these changes
Feb 20, 2024
1670a03
to
23658c7
Compare
dmitry-pedchenko
approved these changes
Feb 20, 2024
23658c7
to
9aee77b
Compare
9aee77b
to
4731d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
See https://onetl--211.org.readthedocs.build/en/211/connection/db_connection/clickhouse/index.html
If new documentation layout will be approved, we can drop generic examples from
JDBC.fetch()
,JDBC.execute()
,JDBC.sql()
,JDBC.JDBCOptions
and so on, and replace them with DB-specific documentation and examples.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)