Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13337] Add Pydantic v2 support #230

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[DOP-13337] Add Pydantic v2 support #230

merged 1 commit into from
Mar 6, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 5, 2024

Change Summary

Related issue number

Allow using onETL with both Pydantic v1 and v2. Thank to Pydantic v2 compatibility layer from pydantic.v1 import ....

Updated CI workflows to include Pydantic version in test matrix.

A lot of lines were changed, but this is mostly copy-paste.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.28%. Comparing base (a994486) to head (6758359).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #230      +/-   ##
===========================================
+ Coverage    94.12%   94.28%   +0.16%     
===========================================
  Files          204      204              
  Lines         7841     8012     +171     
  Branches      1401     1401              
===========================================
+ Hits          7380     7554     +174     
+ Misses         336      334       -2     
+ Partials       125      124       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit f92c602 into develop Mar 6, 2024
53 checks passed
@dolfinus dolfinus deleted the feature/DOP-13337 branch March 6, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants