Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13681] Allow empty pipeline in MongoDB.pipeline #237

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 14, 2024

Change Summary

Sometimes it is handy to just fetch some data from MongoDB to see infered schema. But MongoDB.pipeline requires to pass pipeline={...} argument, so users have to pass here some nonsense to bypass this.

Now this argument is optional.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (02ba65a) to head (85e64eb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #237   +/-   ##
========================================
  Coverage    94.39%   94.39%           
========================================
  Files          204      204           
  Lines         7880     7882    +2     
  Branches      1401     1403    +2     
========================================
+ Hits          7438     7440    +2     
  Misses         317      317           
  Partials       125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review March 15, 2024 09:04
@dolfinus dolfinus merged commit 9c8ccf2 into develop Mar 15, 2024
33 checks passed
@dolfinus dolfinus deleted the feature/DOP-13681-1 branch March 15, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants