Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13852] - upgrade MSSQL packages #254

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Apr 17, 2024

Change Summary

  • MSSQL connection now uses Microsoft SQL Server JDBC driver 12.7.0, upgraded from 12.2.0, and supports passing custom versions: MSSQL.get_packages(java_version=..., package_version=...).
  • Update following documentation and tests.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus
Copy link
Member

Кажется именно для 12.7 нет jre8 и jre11, есть только jre8-preview и jre11-preview: https://mvnrepository.com/artifact/com.microsoft.sqlserver/mssql-jdbc

Да и в документации его тоже пока нет: https://learn.microsoft.com/en-us/sql/connect/jdbc/microsoft-jdbc-driver-for-sql-server-support-matrix?view=sql-server-ver16#java-and-jdbc-specification-support

Давай пока остановимся на 12.6.1.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (8e0dc89) to head (8f12c3c).

❗ Current head 8f12c3c differs from pull request most recent head 4ce1c6d. Consider uploading reports for the commit 4ce1c6d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
+ Coverage    94.39%   94.40%   +0.01%     
===========================================
  Files          204      204              
  Lines         7901     7905       +4     
  Branches      1402     1402              
===========================================
+ Hits          7458     7463       +5     
+ Misses         318      317       -1     
  Partials       125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov merged commit afa1b99 into develop Apr 18, 2024
29 of 30 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-13852 branch April 18, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants