Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13840] - add JSON.parse_column and JSON.serialize_column methods #257

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Apr 19, 2024

Change Summary

  • Add JSON.parse_column and JSON.serialize_column methods to facilitate direct parsing of JSON strings into Spark DataFrame columns and serialization of structured DataFrame columns back into JSON strings.
  • Update following tests and documentation

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov self-assigned this Apr 19, 2024
@maxim-lixakov maxim-lixakov changed the title Feature/dop 13840 [DOP-13840] - add JSON.parse_column and JSON.serialize_column methods Apr 19, 2024
onetl/file/format/json.py Outdated Show resolved Hide resolved
onetl/file/format/json.py Outdated Show resolved Hide resolved
onetl/file/format/json.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.39%. Comparing base (511a330) to head (315478f).

❗ Current head 315478f differs from pull request most recent head 5976497. Consider uploading reports for the commit 5976497 to get more accurate results

Files Patch % Lines
onetl/file/format/json.py 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #257      +/-   ##
===========================================
- Coverage    94.39%   94.39%   -0.01%     
===========================================
  Files          204      204              
  Lines         7910     7926      +16     
  Branches      1402     1404       +2     
===========================================
+ Hits          7467     7482      +15     
  Misses         318      318              
- Partials       125      126       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov enabled auto-merge (squash) April 23, 2024 10:43
@maxim-lixakov maxim-lixakov merged commit b296810 into develop Apr 23, 2024
35 of 36 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-13840 branch April 23, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants