Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13845] - implement Avro.parse_column, Avro.serialize_column #265

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Apr 26, 2024

Change Summary

  • Add Avro.parse_column and Avro.serialize_column methods to enhance the handling of Avro binary data within Spark.
  • Add following tests and documentation.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov self-assigned this Apr 26, 2024
onetl/file/format/avro.py Outdated Show resolved Hide resolved
onetl/file/format/avro.py Outdated Show resolved Hide resolved
onetl/file/format/avro.py Outdated Show resolved Hide resolved
onetl/file/format/avro.py Outdated Show resolved Hide resolved
onetl/file/format/avro.py Outdated Show resolved Hide resolved
@dolfinus
Copy link
Member

Тест на 2.4 падает

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (96ce940) to head (9948f1d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #265      +/-   ##
===========================================
+ Coverage    94.34%   94.45%   +0.10%     
===========================================
  Files          204      204              
  Lines         7963     8002      +39     
  Branches      1408     1414       +6     
===========================================
+ Hits          7513     7558      +45     
+ Misses         325      321       -4     
+ Partials       125      123       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov merged commit 6fc5991 into develop Apr 27, 2024
52 of 53 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-13845 branch April 27, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants