Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-15547] Use official MSSQL docker image #266

Merged
merged 1 commit into from May 2, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Apr 26, 2024

Change Summary

Change MSSQL image from mcmoe/mssqldocker (only v2017 builds, haven't updated for 3 years) to official Microsoft image mcr.microsoft.com/mssql/server (available v2017..v2022). This implies adding custom entrypoint which creates database and non-admin user, as this image does not create user and database automatically.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Apr 26, 2024
@dolfinus dolfinus self-assigned this Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (4f55fdc) to head (48bb8c0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #266      +/-   ##
===========================================
- Coverage    94.45%   94.43%   -0.03%     
===========================================
  Files          204      204              
  Lines         7978     7978              
  Branches      1403     1403              
===========================================
- Hits          7536     7534       -2     
- Misses         319      320       +1     
- Partials       123      124       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review April 26, 2024 12:36
@dolfinus dolfinus merged commit 10ab370 into develop May 2, 2024
37 checks passed
@dolfinus dolfinus deleted the feature/DOP-15547-mssql branch May 2, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants