Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13846] - implement XML.parse_column #269

Merged
merged 7 commits into from
May 3, 2024
Merged

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Apr 27, 2024

Change Summary

  • Add XML.parse_column method for handling XML data within Spark. This method allows for direct parsing of XML strings into structured Spark DataFrame columns.
  • Add following tests and documentation.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

onetl/file/format/xml.py Outdated Show resolved Hide resolved
onetl/file/format/xml.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (5417dc5) to head (3e29dc8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #269      +/-   ##
===========================================
+ Coverage    94.44%   94.48%   +0.03%     
===========================================
  Files          204      204              
  Lines         7999     8012      +13     
  Branches      1404     1405       +1     
===========================================
+ Hits          7555     7570      +15     
+ Misses         320      319       -1     
+ Partials       124      123       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

onetl/file/format/xml.py Outdated Show resolved Hide resolved
onetl/file/format/xml.py Outdated Show resolved Hide resolved
@maxim-lixakov maxim-lixakov merged commit 076d073 into develop May 3, 2024
36 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-13846 branch May 3, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants