Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-15764] Remove fetchsize from JDBCWriteOptions #288

Merged
merged 1 commit into from
May 27, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented May 27, 2024

Change Summary

Currently JDBC.WriteOptions have fetchsize option. This should not be the case.

Instead of inheriting JDBC.ReadOptions, JDBC.SQLOptions and JDBC.WriteOptions from legacy JDBC.JDBCOptions, inherit them from GenericOptions. Copy query_timeout` to both of these classes, as Spark can accept this option in both read and write operations.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.79%. Comparing base (fc9c750) to head (a6deb0e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #288   +/-   ##
========================================
  Coverage    94.78%   94.79%           
========================================
  Files          210      210           
  Lines         8172     8185   +13     
  Branches      1409     1409           
========================================
+ Hits          7746     7759   +13     
  Misses         304      304           
  Partials       122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit 47a8ee3 into develop May 27, 2024
41 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-15764 branch May 27, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants