Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-6700] Add BaseFileDFConnection & BaseFileFormat classes #66

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jul 11, 2023

Change Summary

Added new base classes:

  • BaseFileDFConnection
  • BaseFileFormat

Implementation may change in future pull requests.

Also renamed existing methods of BaseDBConnection: read_df -> read_source_as_df, write_df -> write_df_as_files. This is breaking change, so upgraded version to 0.9.0

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jul 11, 2023
@dolfinus dolfinus temporarily deployed to test-pypi July 11, 2023 09:07 — with GitHub Actions Inactive
@dolfinus dolfinus changed the title [DOP-7051] Revert: Update default logging format [DOP-6700] Add BaseFileDFConnection & BaseFileFormat classes Jul 11, 2023
@dolfinus dolfinus temporarily deployed to test-pypi July 11, 2023 09:40 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi July 11, 2023 09:41 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi July 11, 2023 09:51 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #66 (230dcdd) into develop (d4c39da) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #66      +/-   ##
===========================================
+ Coverage    93.14%   93.16%   +0.01%     
===========================================
  Files          127      129       +2     
  Lines         6131     6146      +15     
  Branches      1149     1149              
===========================================
+ Hits          5711     5726      +15     
  Misses         322      322              
  Partials        98       98              
Impacted Files Coverage Δ
onetl/base/base_db_connection.py 100.00% <ø> (ø)
onetl/base/__init__.py 100.00% <100.00%> (ø)
onetl/base/base_file_df_connection.py 100.00% <100.00%> (ø)
onetl/base/base_file_format.py 100.00% <100.00%> (ø)
onetl/connection/db_connection/greenplum.py 69.62% <100.00%> (ø)
onetl/connection/db_connection/hive.py 91.59% <100.00%> (ø)
onetl/connection/db_connection/jdbc_connection.py 95.81% <100.00%> (ø)
onetl/connection/db_connection/kafka/connection.py 91.20% <100.00%> (ø)
onetl/connection/db_connection/mongodb.py 94.09% <100.00%> (ø)
onetl/db/db_reader/db_reader.py 90.05% <100.00%> (ø)
... and 1 more

@dolfinus dolfinus temporarily deployed to test-pypi July 11, 2023 11:26 — with GitHub Actions Inactive
@dolfinus dolfinus marked this pull request as ready for review July 11, 2023 11:33
@dolfinus dolfinus enabled auto-merge (squash) July 11, 2023 11:50
@dolfinus dolfinus merged commit f4affb6 into develop Jul 12, 2023
39 checks passed
@dolfinus dolfinus deleted the feature/DOP-6700 branch July 12, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants