Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Org code option2 #105

Merged
merged 22 commits into from
Jul 27, 2021
Merged

Org code option2 #105

merged 22 commits into from
Jul 27, 2021

Conversation

cvvergara
Copy link
Contributor

This organizes de C code as follows

include
├── general
├── npoint
└── point
src
├── general
├── npoint
└── point

Some comments about this can be found in and bellow
#85 (comment)

@cvvergara
[inlcude] organizing subdirectory general
81450d7
@cvvergara
[src] dos2unix applied to file and adjusted to include locations
2d7a52d
@cvvergara
[src] adjusted to include location
509cb6b
@cvvergara
[inlcude] organizing subdirectory point
6db582f
@cvvergara
[src] adjusted to include/point location
e96b91a
@cvvergara
[inlcude] organizing subdirectory npoint
6a5b1ae
@cvvergara
[src] adjusted to include/npoint location
bd8b354
@cvvergara
[build] removing useless include_directories and grouping mobilitydb
4b2cd16 
parts
@cvvergara
[src] Organizing general subdirectory
635f3d6
@cvvergara
[build] using new location
8ecf8f5
@cvvergara
[src] Organizing point subdirectory
aa7c7a5
@cvvergara
[build] adding CMakeLists files
6882b19
@cvvergara
[build] Using the changes
bf50533
@cvvergara
[src] Organizing npoint subdirectory
e00d37d
@cvvergara
[build] adding CMakeLists files
e075b98
@cvvergara
[build] Using the changes
c90fb1a
@cvvergara
[build] removing unused code
1e117f9
@cvvergara
[build] removing unused definition
7a0ee0b
@cvvergara
[build] fixing some issues about library version
42d7772
@cvvergara
[build] adding the control file
ea7cd74
@estebanzimanyi
Copy link
Member

I also prefer option 2 for organizing the includes ! Thanks !

@cvvergara cvvergara marked this pull request as ready for review July 27, 2021 15:40
@cvvergara cvvergara merged commit a61c886 into MobilityDB:develop Jul 27, 2021
@cvvergara cvvergara deleted the org-code-option2 branch July 27, 2021 16:03
@cvvergara
Copy link
Contributor Author

@estebanzimanyi gracias

@cvvergara cvvergara mentioned this pull request Jul 27, 2021
Closed
10 tasks
@cvvergara cvvergara restored the org-code-option2 branch July 27, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanzimanyi estebanzimanyi estebanzimanyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cvvergara @estebanzimanyi