Documentation + tests3 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pymeos/pymeos/boxes/stbox.py # pymeos/pymeos/main/tfloat.py # pymeos/tests/boxes/tbox_test.py # pymeos/tests/main/tfloat_test.py # pymeos/tests/main/tint_test.py # pymeos_cffi/pymeos_cffi/__init__.py # pymeos_cffi/pymeos_cffi/builder/build_helpers.py # pymeos_cffi/pymeos_cffi/builder/build_pymeos_functions.py # pymeos_cffi/pymeos_cffi/builder/build_pymeos_functions_modifiers.py # pymeos_cffi/pymeos_cffi/builder/meos.h # pymeos_cffi/pymeos_cffi/functions.py # pymeos_cffi/test.py
Removed STBox as a valid input type in the expand method within the stbox.py file. The same output should be obtained with the union method.
The expand function now only accepts numeric and temporal types as arguments, thus excluding TBox type. This simplification attempts to make the code cleaner and easier to manage. Refactored the union method to merge boxes by default even if they do not intersect. Added an optional parameter 'strict' that when set true, preserves the old behaviour, i.e., fails if the boxes do not intersect. Fixed return type in round method Corrected the round method's return type. Previously it was wrongly marked as STBox, it's now correctly marked as TBox.
…os_cffi and examples.
Diviloper
added
documentation
estebanzimanyi
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate all recent progress into develop for the beta release.
Includes the documentation added in the
documentationbranch and the tests implemented in thetests3branch