Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Remove Best Practices merged into spec #59

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

Sergiodero
Copy link
Contributor

Best Practice Proposal:

Referenced from issue #57

A recently implemented proposal has merged specific best practices directly into the GTFS specification. This merge included content from the following files under the Practice Recommendations Organized by File section:

  • agency.txt
  • routes.txt
  • stop_times.txt
  • fare_attributes.txt
  • shapes.txt
  • feed_info.txt

This proposal removes the duplicated content from the Best Practices document, to avoid duplicity and consolidating a single source of truth.

Removing content coded into reference.md from BP:

- agency.agency_id
- routes.agency_id
- routes.route_short_name
- stop_times.shape_dist_traveled
- stop_times.timepoint
- fare_attributes.agency_id
- shapes.shape_dist_traveled
- feed_info.txt
Added `shape_dist_traveled` field name under shapes.txt table
@Sergiodero Sergiodero changed the title Remove bp merged into spec Remove Best Practices merged into spec Aug 14, 2023
@emmambd emmambd linked an issue Aug 15, 2023 that may be closed by this pull request
@Sergiodero
Copy link
Contributor Author

As this PR has been open for more than a week, I'm calling a vote as per the process outlined in the GTFS Schedule Best Practices Amendment Process.

This vote is for the removal of best practices content that have migrated over to the GTFS spec.

Voting ends on 2023-08-29 at 23:59:59 UTC.

Thanks

@markstos
Copy link

+1 RideAmigos

@skinkie
Copy link

skinkie commented Aug 23, 2023

+1 OpenGeo

@bdferris-v2
Copy link

+1 Google

@Sergiodero
Copy link
Contributor Author

The vote ended on 2023-08-29 at 23:59:59 UTC. This PR passes with 3 votes in favor (from RideAmigos, OpenGeo & Google) and 0 opposed!

Thanks to everyone who participated!

Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Sergio!
I cross-checked this PR with the spec. Everything is covered.

Thank you for working on this, ready to merge :)

@isabelle-dr isabelle-dr merged commit 09fa31c into master Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove best practices now merged into the spec
6 participants