Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to validate Link Granada #90

Closed
josee-sabourin opened this issue Jan 31, 2023 · 7 comments · Fixed by #177
Closed

Unable to validate Link Granada #90

josee-sabourin opened this issue Jan 31, 2023 · 7 comments · Fixed by #177
Assignees
@Alessandro100
Labels
bug Something isn't working

Comments

@josee-sabourin
Copy link
Contributor

Error when validating https://mds.linkyour.city/gbfs/es_granada/gbfs.json.
"Sorry, this version is not yet implemented or not detectable !", even when specifying the version, same error message.
@josee-sabourin josee-sabourin added the bug Something isn't working label Jan 31, 2023
@PierrickP
Copy link
Collaborator

They block the default Got User-Agent

curl -I -H 'User-Agent: got (https://github.com/sindresorhus/got)' https://mds.linkyour.city/gbfs/es_granada/gbfs.json

return 500
But

curl -I https://mds.linkyour.city/gbfs/es_granada/gbfs.json

Works

We could change our user-agent to allow us to be properly identified (eg: gbfs-validator (https://github.com/MobilityData/gbfs-validator))
It is not bullet proof. They can still block it.

@josee-sabourin josee-sabourin mentioned this issue Feb 1, 2023
Merged
@josee-sabourin
Copy link
Contributor Author

@ezmckinn can you provide any insight here? Would Superpedestrian prefer a more identifiable user-agent?

@PierrickP PierrickP mentioned this issue Jun 5, 2023
Open
tdelmas added a commit to tdelmas/gbfs-validator that referenced this issue Jun 28, 2023
@tdelmas
Squashed 'gbfs-validator/versions/schemas/' changes from ef0d9a6..22b…
1074a38 
…058d

22b058d fix: incorrect spec for "languages" property in system_information.json (MobilityData#90)
e9d891b Refer to later versions in gbfs_versions.json (MobilityData#87)
fbd3ced Add v3.0 to v3.0-RC schemas (MobilityData#88)

git-subtree-dir: gbfs-validator/versions/schemas
git-subtree-split: 22b058dc4a358baf451e006cde74775075929b3d
tdelmas added a commit to tdelmas/gbfs-validator that referenced this issue Jun 28, 2023
@tdelmas
Squashed 'gbfs-validator/versions/schemas/' changes from 5273f96..22b…
af854e3 
…058d

22b058d fix: incorrect spec for "languages" property in system_information.json (MobilityData#90)
e9d891b Refer to later versions in gbfs_versions.json (MobilityData#87)
fbd3ced Add v3.0 to v3.0-RC schemas (MobilityData#88)
ef0d9a6 Fix schemas for v3.0-RC (MobilityData#85)
2b6ad1e FIX: replaces name field with localized string (MobilityData#82)
abe71f2 Fix invalid json, no trailing commas (MobilityData#83)
f43170e V3.0-RC Schemas  (MobilityData#79)
680df70 Update pr-to-project.yml
c2c30a2 Typo fix in geofencing_zones.json (MobilityData#78)
c9be765 Create pr-to-project.yml
0a17875 Create issues-to-project.yml
30e5a3a Update README.md

git-subtree-dir: gbfs-validator/versions/schemas
git-subtree-split: 22b058dc4a358baf451e006cde74775075929b3d
richfab pushed a commit that referenced this issue Jun 29, 2023
@tdelmas
Add V3-RC validation (#104)
e3d5f08 
* Git ignore for schemas subtree

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* Squashed 'gbfs-validator/versions/schemas/' changes from 5273f96..22b058d

22b058d fix: incorrect spec for "languages" property in system_information.json (#90)
e9d891b Refer to later versions in gbfs_versions.json (#87)
fbd3ced Add v3.0 to v3.0-RC schemas (#88)
ef0d9a6 Fix schemas for v3.0-RC (#85)
2b6ad1e FIX: replaces name field with localized string (#82)
abe71f2 Fix invalid json, no trailing commas (#83)
f43170e V3.0-RC Schemas  (#79)
680df70 Update pr-to-project.yml
c2c30a2 Typo fix in geofencing_zones.json (#78)
c9be765 Create pr-to-project.yml
0a17875 Create issues-to-project.yml
30e5a3a Update README.md

git-subtree-dir: gbfs-validator/versions/schemas
git-subtree-split: 22b058dc4a358baf451e006cde74775075929b3d

* remove dot files in schemas

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* v3-RC validation

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* Remove unused file

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* Add `serverOpts` required in Windows

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* Fix typo `recommended`

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* update test for 3.0-RC , 3.0 and upcoming minor versions

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* fix after rebase

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* Recommended.

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>

* Squashed 'gbfs-validator/versions/schemas/' changes from 22b058d..5f12243

5f12243 Patch manifest.json (#91)

git-subtree-dir: gbfs-validator/versions/schemas
git-subtree-split: 5f12243d5735a608eef697212a627b9090eea31a

---------

Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>
@josee-sabourin josee-sabourin mentioned this issue Jul 24, 2023
Closed
@richfab richfab mentioned this issue Jul 24, 2023
Closed
2 tasks
@ezmckinn
Copy link

Hi @josee-sabourin and @richfab — thanks for raising this. I actually have struggled to use the GBFS validator in the past, for our own spot-checking, so we'll be glad to work on this. I will file a bug ticket internally and provide on updates on this thread as the fix is processed.

@richfab richfab mentioned this issue Sep 27, 2023
Closed
@richfab
Copy link
Contributor

richfab commented Sep 27, 2023

Hi @ezmckinn,
Do you have an update on the internal bug ticket?
We're happy to provide support if Superpedestrian sees value in using the GBFS validator on its feeds.
Thanks

@josee-sabourin josee-sabourin mentioned this issue Oct 4, 2023
Open
@davidgamez
Copy link
Member

For consistency between MobilityData validators, let's use a similar pattern described here. In this case user agent should be: User-Agent: MobilityData GBFS-Validator/{VALIDATOR_VERSION} ({NODE_VERSION})

@Alessandro100 Alessandro100 mentioned this issue Apr 10, 2024
Merged
@richfab
Copy link
Contributor

richfab commented Apr 17, 2024

Fixed by #177

@richfab richfab closed this as completed Apr 17, 2024
@richfab richfab reopened this Apr 17, 2024
@Alessandro100
Copy link
Contributor

With the latest version bump it should be working now
fixing pr: #182

Screenshot 2024-04-17 at 11 11 32

@richfab richfab closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alessandro100 Alessandro100

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate granada feed through new GOT user-agent MobilityData/gbfs-validator
6 participants
@davidgamez @PierrickP @richfab @Alessandro100 @ezmckinn @josee-sabourin