Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the case for "MultiPolygon" #39

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

fchabouis
Copy link
Contributor

@fchabouis fchabouis commented Oct 7, 2021

I thought I was validating a feed with the validator, but I ended up validating the validator with the feed :)

There seems to be a case typo for virtual_areas expected enum : Multipolygon instead of MultiPolygon.

I give you the corresponding feed if you want to test it : https://data-sharing.tier-services.io/tier_grenoble/gbfs/2.2

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 7, 2021

❌ Deploy Preview for competent-payne-690ca9 failed.

🔨 Explore the source changes: 0e2e2f3

🔍 Inspect the deploy log: https://app.netlify.com/sites/competent-payne-690ca9/deploys/615eff7050e50a00076c84d2

@netlify
Copy link

netlify bot commented Oct 7, 2021

✔️ Deploy Preview for wizardly-lichterman-770f54 canceled.

🔨 Explore the source changes: 0e2e2f3

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-lichterman-770f54/deploys/615eff703f0fea0008bca577

@netlify
Copy link

netlify bot commented Oct 7, 2021

❌ Deploy Preview for wizardly-engelbart-5c48ca failed.

🔨 Explore the source changes: 0e2e2f3

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-engelbart-5c48ca/deploys/615eff708f52f90007221f37

@PierrickP
Copy link
Collaborator

Hello @fchabouis
Thanks for this PR, i ll merge it.

When i started this project, i took the official schemas from https://github.com/MobilityData/gbfs-json-schema and fixed some parts :)

With MobilityData, we would like to re-integrated fixes from here to https://github.com/MobilityData/gbfs-json-schema and use the schemas from gbfs-json-schema on the validator (like git submodule or something that works, we don't know yet).
But before, they need to re-organize the repository to correctly keep old version of the schema.

@PierrickP PierrickP merged commit 596378a into MobilityData:master Oct 7, 2021
@AntoineAugusti AntoineAugusti mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants