Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to vehicle_types #470

Merged
merged 3 commits into from Jan 23, 2023
Merged

Conversation

j0kan
Copy link
Contributor

@j0kan j0kan commented Nov 30, 2022

We found it useful at nextbike to show vehicle-type specific texts to our customers.

https://github.com/MobilityData/gbfs/wiki/Extensions-outside-of-the-specification

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

vehicle_types.json

We found it useful to show vehicle-type specific texts to our customers
@CLAassistant
Copy link

CLAassistant commented Nov 30, 2022

CLA assistant check
All committers have signed the CLA.

@josee-sabourin
Copy link
Contributor

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Friday, January 20th.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

@josee-sabourin josee-sabourin added Vote open v3.0-RC Candidate change for GBFS 3.0 (Major release) labels Jan 10, 2023
@cmonagle
Copy link
Contributor

+1 from Transit, but, pending approval, this should also be a localized array.

@testower
Copy link
Contributor

+1 from Entur

@bdferris-v2
Copy link
Contributor

This proposal doesn't seem particularly controversial, but to the point raised by @cmonagle, it does feel like it should be a localized string array, assuming #460 goes through. I'll admit I'm not super familiar with GBFS voting and governance, but would switching that later require another vote? Or do you think this would go in before #460?

@testower
Copy link
Contributor

@bdferris-v2 Yes it's been raised already in other channels but you're right. Whichever gets merged first, the other PR needs to be updated.

@josee-sabourin
Copy link
Contributor

Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

@kheraankit
Copy link

+1 from Lime

@benwedge
Copy link

+1 from Joyride, though this is not something we would use in the short term

@fbouchPBSC
Copy link
Contributor

+1 from PBSC

@cait32
Copy link

cait32 commented Jan 19, 2023

+1 from BCycle

@rickbruce
Copy link

+1 from Ito

@ezmckinn
Copy link
Contributor

+1 from Superpedestrian.

@schnuerle
Copy link
Contributor

+1 looks good to the OMF staff

@josee-sabourin
Copy link
Contributor

This vote has now closed, and it passes!

Votes in favor:
Transit (consumer)
Google Maps (consumer)
Entur (consumer)
Superpedestrian (producer)
Lime (producer)
Joyride (producer)
PBSC (producer)
BCycle (producer)
Ito World (producer)
OMF (3rd party)

There were no votes against.
Thank you to everyone who took the time to review and to vote on this! We incorporate it into 3.0-RC, which should be ready to go in the coming week.

Note: The changes proposed in #460 will be applied to this change.

@josee-sabourin josee-sabourin merged commit d53e2a6 into MobilityData:master Jan 23, 2023
josee-sabourin added a commit that referenced this pull request Jan 23, 2023
Adds in-line annotations to changes made in v3.0-RC (#460, #454, #457, #462, #470)
Removes "RC" from annotations in v2.3-RC and RC2
josee-sabourin added a commit that referenced this pull request Jan 23, 2023
* Add versions to new and updated fields

Adds in-line annotations to changes made in v3.0-RC (#460, #454, #457, #462, #470)
Removes "RC" from annotations in v2.3-RC and RC2
Editorial changes
@richfab richfab added the gbfs.md label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md v3.0-RC Candidate change for GBFS 3.0 (Major release) Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet