Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Field - termination_date #497

Merged
merged 2 commits into from Nov 2, 2023

Conversation

mplsmitch
Copy link
Contributor

@mplsmitch mplsmitch commented Mar 21, 2023

Adds a new field, termination_date, to system_information.json to notify data consumers when feeds will be discontinued.

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

The specification lacks a way to notify data consumers when a feed is shutting down permanently and will no longer be available. This has come up a number of times in the past but we have yet to formalize a best practice for feed end of life. Relevant issue with further discussion is #492.

What is the proposal?

Add a field termination_date to system_information.json that contains the date when the feed will go off line. Define best practice for communicating with data consumers about feed end of life.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

gbfs.md > system_information.json

Adds a new field, termination_date, to system_information.json to notify data consumers when feeds will be discontinued
@CLAassistant
Copy link

CLAassistant commented Mar 21, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ richfab
❌ mplsmitch
You have signed the CLA already but the status is still pending? Let us recheck it.

@mplsmitch
Copy link
Contributor Author

mplsmitch commented Apr 24, 2023

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on May 4th.
Please vote for or against the proposal, and include the organization for which you are voting in your comment.
Please note if you can commit to implementing the proposal.

A few notes on voting:

  • Anyone may vote on a proposal. You do not need to be a member of MobilityData.
  • A vote passes if there is unanimous consensus with at least 3 votes in favor.
  • At least one of the 3 votes MUST be from a GBFS producer and at least one MUST be from a GBFS consumer.
  • Votes against a proposal can stop it from passing if they provide a specific reason for voting against and contain actionable feedback.
  • If you represent an organization, only one vote per organization will be counted.

CC: @mwillmott

@mwillmott
Copy link
Contributor

Note that the original comment refers to station_information.json but i believe it is meant to be system_information.json as reflected in the actual changes made.

On that basis, Lyft (operator) votes for this proposal.

cc @ArashMansouri

@mplsmitch
Copy link
Contributor Author

Note that the original comment refers to station_information.json but i believe it is meant to be system_information.json as reflected in the actual changes made.

@mwillmott thanks for catching that, I've corrected it

@futuretap
Copy link
Contributor

+1 from FutureTap / Where To? (consumer)

@cmonagle
Copy link
Contributor

+1 from Transit

@benwedge
Copy link

+1 from Joyride

@fbouchPBSC
Copy link
Contributor

+1 from PBSC

@josee-sabourin
Copy link
Contributor

Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

@ezmckinn
Copy link
Contributor

ezmckinn commented May 4, 2023

+1 Superpedestrian supports this proposal.

@josee-sabourin
Copy link
Contributor

This vote has now closed, and it passes!

Votes in favor:
FutureTap / Where To? (consumer)
Transit (consumer)
Joyride (producer)
PBSC (producer)
Superpedestrian (producer)

There were no votes against.

Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gbfs.md Outdated Show resolved Hide resolved
@richfab richfab merged commit 90beeae into MobilityData:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md v3.0-RC2 Candidate change for GBFS 3.0 (Major release) - 2nd pass Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants