Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Validator after addition of trip-to-trip and route-to-route transfers #1114

Closed
isabelle-dr opened this issue Mar 15, 2022 · 2 comments · Fixed by #1208
Closed

Update Validator after addition of trip-to-trip and route-to-route transfers #1114

isabelle-dr opened this issue Mar 15, 2022 · 2 comments · Fixed by #1208
Assignees
@KClough
Labels
good first issue Good task for newcomers to work on. GTFS Reference Used for Adding or changing rules that belong in the GTFS reference
Projects
The Tech Dashboard (archived)

Comments

@isabelle-dr
Copy link
Contributor

isabelle-dr commented Mar 15, 2022 •
edited
Loading

In Q4 2021, trip-to-trip and route-to-route transfers were added to the specification (PR#284).

The validator needs to be updated with 4 additional optional fields in transfers.txt:

  • from_trip_id - Foreign key referencing trips.trip_id
  • to_trip_id - Foreign key referencing trips.trip_id
  • from_route_id - Foreign key referencing routes.route_id
  • to_route_id - Foreign key referencing routes.route_id

No additional rules need to be added.

Definition of done:
@isabelle-dr isabelle-dr added the GTFS Reference Used for Adding or changing rules that belong in the GTFS reference label Mar 15, 2022
@isabelle-dr isabelle-dr added this to the Rules improvements milestone Mar 15, 2022
@isabelle-dr isabelle-dr added the good first issue Good task for newcomers to work on. label Mar 15, 2022
@isabelle-dr isabelle-dr mentioned this issue Mar 15, 2022
Closed
@maximearmstrong maximearmstrong added this to GTFS Schedule - Validator in The Tech Dashboard (archived) Apr 21, 2022
@isabelle-dr isabelle-dr modified the milestones: Rules improvements, Keep up-to-date with the spec May 26, 2022
@KClough KClough self-assigned this Jul 8, 2022
@KClough KClough mentioned this issue Jul 10, 2022
Merged
4 tasks
@KClough
Copy link
Collaborator

KClough commented Jul 10, 2022

@isabelle-dr please let me know if I should be updating the status of things on this board. I didn't see a way for me to set that status from Current Sprint to Under Review.

@KClough KClough linked a pull request Jul 10, 2022 that will close this issue
feat: add trip-to-trip and route-to-route fields to transfers #1208
Merged
4 tasks
@maximearmstrong maximearmstrong moved this from GTFS Schedule - Validator to In Progress in The Tech Dashboard (archived) Jul 11, 2022
@maximearmstrong
Copy link
Contributor

maximearmstrong commented Jul 11, 2022 •
edited
Loading

@isabelle-dr please let me know if I should be updating the status of things on this board. I didn't see a way for me to set that status from Current Sprint to Under Review.

I just updated it :) Thank you @KClough ! Can you update it via the projects section (right bar) of this issue?

The Tech Dashboard (archived) automation moved this from In Progress to Done Jul 11, 2022
@isabelle-dr isabelle-dr mentioned this issue Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KClough KClough

Labels
good first issue Good task for newcomers to work on. GTFS Reference Used for Adding or changing rules that belong in the GTFS reference
Projects
No open projects
The Tech Dashboard (archived)
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add trip-to-trip and route-to-route fields to transfers JarvusInnovations/gtfs-validator
3 participants
@KClough @maximearmstrong @isabelle-dr