Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trip-to-trip and route-to-route fields to transfers #1208

Conversation

KClough
Copy link
Collaborator

@KClough KClough commented Jul 10, 2022

Summary:

Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).

#1114

Expected behavior:

Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@KClough KClough changed the title add trip-to-trip and route-to-route fields to transfers feat: add trip-to-trip and route-to-route fields to transfers Jul 10, 2022
@maximearmstrong
Copy link
Contributor

I modified the London Transit Commission dataset, which already implements transfers.txt, to test these changes.

Pre changes:
Capture d’écran, le 2022-07-11 à 17 29 48

Post changes:
Capture d’écran, le 2022-07-11 à 17 30 24
Capture d’écran, le 2022-07-11 à 17 33 05

I confirm that the behavior is correct.

Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @KClough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update Validator after addition of trip-to-trip and route-to-route transfers
2 participants