Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether expired services (calendars) exist on schedule feed #1279

Closed
owades opened this issue Oct 18, 2022 · 6 comments · Fixed by #1289
Closed

Check whether expired services (calendars) exist on schedule feed #1279

owades opened this issue Oct 18, 2022 · 6 comments · Fixed by #1289
Labels
GTFS Best Practices Used for Adding or changing rules that belong in the GTFS Best Practices new rule New rule to be added status: Ready An issue that is ready to be worked on.

Comments

@owades
Copy link

owades commented Oct 18, 2022 •
edited
Loading

Describe the problem

The GTFS Best Practices include the following best practice:

Remove old services (expired calendars) from the feed.

We don't have a check that looks for expired calendars

Describe the new validation rule

If there exists a row in calendar.txt with end_date < TODAY_DATE, or a row in calendar_dates.txt with date < TODAY_DATE, trigger an "expired_calendar" notice

Sample GTFS datasets

No response

Severity

Warning

Additional context

No response
@owades owades added new rule New rule to be added status: Needs triage Applied to all new issues labels Oct 18, 2022
@isabelle-dr isabelle-dr added status: Ready An issue that is ready to be worked on. GTFS Best Practices Used for Adding or changing rules that belong in the GTFS Best Practices and removed status: Needs triage Applied to all new issues labels Nov 3, 2022
@isabelle-dr
Copy link
Contributor

This sounds good, thanks for opening this!

@bradyhunsaker
Copy link
Contributor

I will give this a try. I am inclined to rename the file MissingCalendarAndCalendarDateValidator.java as CalendarAndCalendarDateValidator.java and include these checks there.

Any concerns about renaming a file like that?

@isabelle-dr
Copy link
Contributor

No concerns, you can go ahead.
(cc @bdferris-v2)

@bradyhunsaker
Copy link
Contributor

I was working on this, but I just realized I think it is a duplicate of (part of) #886
Could you confirm that?

@isabelle-dr isabelle-dr linked a pull request Mar 10, 2023 that will close this issue
feat: Date validity - Calendar Expiration + Trip Coverage #1289
Merged
4 tasks
@isabelle-dr
Copy link
Contributor

You are right, this issue looks like the second portion of #886!
Please note that @KClough started to work on this in #1289

@isabelle-dr
Copy link
Contributor

Closing, duplicate of #886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GTFS Best Practices Used for Adding or changing rules that belong in the GTFS Best Practices new rule New rule to be added status: Ready An issue that is ready to be worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Date validity - Calendar Expiration + Trip Coverage JarvusInnovations/gtfs-validator
3 participants
@owades @bradyhunsaker @isabelle-dr