Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Validator: add link details to results page #1395

Closed
2 tasks
themightychris opened this issue Apr 20, 2023 · 4 comments · Fixed by #1397
Closed
2 tasks

Web Validator: add link details to results page #1395

themightychris opened this issue Apr 20, 2023 · 4 comments · Fixed by #1397

Comments

@themightychris
Copy link
Collaborator

@ryon

On the results page, add:

  • a notice informing the user that they can share the URL of their results with others for at least 30 days
  • a link the report.json file that is right next to report.html in the storage bucket
@isabelle-dr
Copy link
Contributor

Good idea!
Am I understanding correctly that the URL link itself is only working for 30 days?

Would be nice to have an option that allows the user to copy the URL in one click.
The flow could be (similar to other "share" functionalities).

  • click on a Share button
  • copy the URL link

@themightychris
Copy link
Collaborator Author

@isabelle-dr well the links will work until we purge results and a process for actually purging aged results isn't in our immediate scope, so right now they'll work indefinitely... but we want to set conservative expectations

Good point re: a handy way to copy, I'll leave that to @ryon's consideration

@isabelle-dr
Copy link
Contributor

Ok that makes sense.

For the JSON -> you thinking of adding a download link or will it be an online instance of the JSON?

@ryon ryon mentioned this issue Apr 22, 2023
4 tasks
@ryon
Copy link
Collaborator

ryon commented Apr 22, 2023

See my PR for more details: #1397

validator-json-copy.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants