-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: report link sharing #1397
feat: report link sharing #1397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
One clarifying question: is the link to JSON a download of the JSON, or is it a link to an online instance of it? |
@isabelle-dr it's a direct link to the static JSON file, what happens when people click on it will depend on how their browser is set up. Developers will commonly have a JSON viewer extension installed which will open it in their browser with formatting. In most cases, to download it someone would have to right click and select Save or open it and then File->Save. To test ahead of getting merged and deployed to the public instance, you'd need to follow the steps under |
Quick note: you shouldn't need to set up the Java backend to build and test the UI. The web app will connect to the existing cloud service. |
Summary
?report=[id]
), so that results can be referred to laterExpected behavior
New "ready" modal
Confirmation of clipboard operation
"error" status modal when trying to load a page with an invalid id in the query
Checklist
gradle test
to make sure you didn't break anything