Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong fieldName in missing_recommanded_field notice #1574

Closed
jcpitre opened this issue Sep 14, 2023 · 0 comments · Fixed by #1706
Closed

Wrong fieldName in missing_recommanded_field notice #1574

jcpitre opened this issue Sep 14, 2023 · 0 comments · Fixed by #1706
Labels
bug Something isn't working (crash, a rule has a problem) good first issue Good task for newcomers to work on. status: Ready An issue that is ready to be worked on.

Comments

@jcpitre
Copy link
Contributor

jcpitre commented Sep 14, 2023 •
edited
Loading

Describe the bug

Ran the validator with a deliberate error: I removed the agency_id from the line in agency.txt.
It gave the right notice but the fieldName read "Avalon Transit" where we would expect something like: "agency_id"

Steps/Code to Reproduce

Use this dataset with the web validator:
test.zip

Unfortunately the version info we have is 4.1.1-SNAPSHOT (BTW the production web validator should have a release version number)

Expected Results

"agency_id" as the firld name

Actual Results

"Avalon Transit" as the field name

Screenshots

image

Files used

No response

Validator version

4.1.1-SNAPSHOT

Operating system

MacOS

Java version

No response

Additional notes

No response
@jcpitre jcpitre added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues labels Sep 14, 2023
@emmambd emmambd added status: Ready An issue that is ready to be worked on. good first issue Good task for newcomers to work on. and removed status: Needs triage Applied to all new issues labels Jan 11, 2024
michaelandrewkearney added a commit to michaelandrewkearney/gtfs-validator that referenced this issue Mar 11, 2024
@michaelandrewkearney
fix: correct field name in missing_recommended_field_notice (Mobility…
61047d5 
…Data#1574)
Merged
5 tasks
davidgamez pushed a commit that referenced this issue Mar 12, 2024
@michaelandrewkearney
fix: correct field name in missing_recommended_field_notice (#1574) (#…
dee5802 
…1706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working (crash, a rule has a problem) good first issue Good task for newcomers to work on. status: Ready An issue that is ready to be worked on.
Projects
Bug triage
Status: Done
Milestone
No milestone
2 participants
@emmambd @jcpitre