Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade LocationWithUnexpectedStopTimeNotice to ERROR #1021

Merged

Conversation

lionel-nj
Copy link
Contributor

@lionel-nj lionel-nj commented Oct 4, 2021

closes #1017
Summary:

This PR provides support to upgrade LocationWithUnexpectedStopTimeNotice to ERROR.

Expected behavior:

LocationWithUnexpectedStopTimeNotice:

Referenced locations must be stops/platforms, i.e. their stops.location_type value must be 0 or empty.
https://github.com/google/transit/blob/master/gtfs/spec/en/reference.md#stop_timestxt

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • [ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@lionel-nj lionel-nj changed the title chore: chore: upgrade LocationWithUnexpectedStopTimeNotice to ERROR Oct 4, 2021
@lionel-nj lionel-nj force-pushed the task/change-severity-LocationWithUnexpectedStopTimeNotice branch from 356ff78 to 43dfa1d Compare October 4, 2021 21:00
@lionel-nj lionel-nj marked this pull request as ready for review October 4, 2021 21:05
@lionel-nj lionel-nj mentioned this pull request Oct 4, 2021
3 tasks
@aababilov
Copy link
Collaborator

LGTM

@lionel-nj
Copy link
Contributor Author

Thanks for reviewing @aababilov!

@lionel-nj lionel-nj merged commit a578bbd into master Oct 5, 2021
@lionel-nj lionel-nj deleted the task/change-severity-LocationWithUnexpectedStopTimeNotice branch October 5, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split PR 970 into one PR per rule.
2 participants