Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: False positives for StopTimeTimepointWithoutTimesNotice #1044

Merged
merged 27 commits into from
Nov 16, 2021
Merged

fix: False positives for StopTimeTimepointWithoutTimesNotice #1044

merged 27 commits into from
Nov 16, 2021

Commits on Oct 26, 2021

  1. Emit a notice when timepoint = 1 AND times are missing

    lionel-nj committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a72b888 View commit details
    Browse the repository at this point in the history

  2. Emit a notice (WARNING) when stop_times.timepoint value is missing fo… 

    …r a single record.
    lionel-nj committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    febb426 View commit details
    Browse the repository at this point in the history

  3. update javadocs

    lionel-nj committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    c2fa449 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Merge branch 'master' into fix/timepoint

    lionel-nj committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    b3ec654 View commit details
    Browse the repository at this point in the history

  2. apply suggestion from code review 

    Co-authored-by: Maxime Armstrong <46797220+maximearmstrong@users.noreply.github.com>
    @lionel-nj @maximearmstrong
    lionel-nj and maximearmstrong committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    fc14880 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/timepoint' of github.com:MobilityData/gtfs-validato… 

    …r into fix/timepoint
    lionel-nj committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    d44332a View commit details
    Browse the repository at this point in the history

  4. clarify documentation

    lionel-nj committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    fa647ef View commit details
    Browse the repository at this point in the history

  5. modify rule logic to flag legacy datasets not using timepoint column

    lionel-nj committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    8e91071 View commit details
    Browse the repository at this point in the history

  6. refactor StopTimeTimepointWithoutTimesNotice for code clarity

    lionel-nj committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    c1d8fc3 View commit details
    Browse the repository at this point in the history

  7. update rules documentation

    lionel-nj committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    7497e16 View commit details
    Browse the repository at this point in the history

  8. issue MissingTimepointValueNotice in rule logic

    lionel-nj committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    bab59bf View commit details
    Browse the repository at this point in the history

  9. modify rule logic

    lionel-nj committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    df1f702 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. touch

    lionel-nj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    a2b5e3b View commit details
    Browse the repository at this point in the history

  2. persist metadata

    lionel-nj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    ddf420b View commit details
    Browse the repository at this point in the history

  3. update docs: rename notices

    lionel-nj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    1135049 View commit details
    Browse the repository at this point in the history

  4. no longer persist datasets metadata: to be done in a separate PR [acc… 

    …eptance test skip]
    lionel-nj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    539fc1f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. apply suggestions from code review

    lionel-nj committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    2c62b0a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/timepoint

    lionel-nj committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    62c64c1 View commit details
    Browse the repository at this point in the history

  3. apply goJF

    lionel-nj committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    afa44dc View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. Merge branch 'master' into fix/timepoint

    lionel-nj committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    4420e7d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. apply suggestions from code review 

    - clarify docstrings
- remove use of Strings.format()
    lionel-nj committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    b9dd33f View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Merge branch 'master' into fix/timepoint

    lionel-nj committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    22c59aa View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. remove StopTime record where not needed

    lionel-nj committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    e33c960 View commit details
    Browse the repository at this point in the history

  2. add context to notice upgrade [acceptance test skip]

    lionel-nj committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    dc6462c View commit details
    Browse the repository at this point in the history

  3. apply goJF [acceptance test skip]

    lionel-nj committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    0a74e40 View commit details
    Browse the repository at this point in the history

  4. additional documentation in unit tests [acceptance test skip]

    lionel-nj committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    84926f4 View commit details
    Browse the repository at this point in the history

  5. apply suggestions from code review [acceptance test skip]

    lionel-nj committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    35f47ce View commit details
    Browse the repository at this point in the history