-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade StopTimeTimepointWithoutTimesNotice to ERROR #1068
chore: upgrade StopTimeTimepointWithoutTimesNotice to ERROR #1068
Conversation
This notice is emitted by 44 datasets from the MobilityDatabase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update docs/MIGRATION_V2_V3.md as well?
Besides, LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, otherwise, LGTM!
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TimepointTimeValidator.java
Show resolved
Hide resolved
Thanks for reviewing @asvechnikov2! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #1017
More context
Summary:
This PR provides support to upgrade
StopTimeTimepointWithoutTimeNotice
to ERROR.Expected behavior:
StopTimeTimepointWithoutTimeNotice
:https://github.com/google/transit/blob/master/gtfs/spec/en/reference.md#stop_timestxt
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)