Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade StopTimeTimepointWithoutTimesNotice to ERROR #1068

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

lionel-nj
Copy link
Contributor

@lionel-nj lionel-nj commented Nov 17, 2021

closes #1017
More context
Summary:

This PR provides support to upgrade StopTimeTimepointWithoutTimeNotice to ERROR.

Expected behavior:

  • StopTimeTimepointWithoutTimeNotice:
Field Name Type Presence Description
trip_id ID referencing trips.trip_id Required Identifies a trip.
arrival_time Time Conditionally Required Arrival time at the stop (defined by stop_times.stop_id) for a specific trip (defined by stop_times.trip_id).

If there are not separate times for arrival and departure at a stop, arrival_time and departure_time should be the same.

For times occurring after midnight on the service day, enter the time as a value greater than 24:00:00 in HH:MM:SS local time for the day on which the trip schedule begins.

If exact arrival and departure times (timepoint=1 or empty) are not available, estimated or interpolated arrival and departure times (timepoint=0) should be provided.

Conditionally Required:
- Required for the first and last stop in a trip (defined by stop_times.stop_sequence).
- Required for timepoint=1.
- Optional otherwise.
departure_time Time Conditionally Required Departure time from the stop (defined by stop_times.stop_id) for a specific trip (defined by stop_times.trip_id).

If there are not separate times for arrival and departure at a stop, arrival_time and departure_time should be the same.

For times occurring after midnight on the service day, enter the time as a value greater than 24:00:00 in HH:MM:SS local time for the day on which the trip schedule begins.

If exact arrival and departure times (timepoint=1 or empty) are not available, estimated or interpolated arrival and departure times (timepoint=0) should be or

https://github.com/google/transit/blob/master/gtfs/spec/en/reference.md#stop_timestxt

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • [ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@lionel-nj lionel-nj changed the title upgrade notice: WARNING -> ERROR [acceptance test skip] chore: upgrade StopTimeTimepointWithoutTimesNotice to ERROR Nov 17, 2021
@lionel-nj lionel-nj self-assigned this Nov 17, 2021
@lionel-nj
Copy link
Contributor Author

This notice is emitted by 44 datasets from the MobilityDatabase.

Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update docs/MIGRATION_V2_V3.md as well?
Besides, LGTM, thanks!

Copy link
Collaborator

@asvechnikov2 asvechnikov2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, otherwise, LGTM!

RULES.md Outdated Show resolved Hide resolved
docs/MIGRATION_V2_V3.md Outdated Show resolved Hide resolved
@lionel-nj
Copy link
Contributor Author

Thanks for reviewing @asvechnikov2!

Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lionel-nj lionel-nj merged commit 95782bd into master Nov 18, 2021
@lionel-nj lionel-nj deleted the task/upgrade-StopTimeTimepointWithoutTimeNotice branch November 18, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split PR 970 into one PR per rule.
4 participants