Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Maven central #1090

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Conversation

ed-g
Copy link
Contributor

@ed-g ed-g commented Jan 31, 2022

Summary:

Maven central for #1086 (comment)

@ed-g ed-g changed the title Maven central build: Maven central Jan 31, 2022
@lionel-nj lionel-nj self-requested a review February 1, 2022 14:58
Copy link
Contributor

@lionel-nj lionel-nj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For information Rule acceptance tests fails because the PR merges code from another github repository that does not have access to the credentials required to set up and authorize the usage GCP. Since this code does not affect validation logic, I'll merge to the master branch.

Thank you for this improvement @ed-g!

@ed-g
Copy link
Contributor Author

ed-g commented Feb 2, 2022

you're welcome @lionel-nj :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants