Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Jitpack #1099

Merged
merged 17 commits into from
Feb 9, 2022
Merged

build: Jitpack #1099

merged 17 commits into from
Feb 9, 2022

Conversation

lionel-nj
Copy link
Contributor

@lionel-nj lionel-nj commented Feb 3, 2022

Summary:

This is a fix to support build on jitpack.io
Expected behavior:

The project should build.

See logs.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@MobilityData MobilityData deleted a comment from github-actions bot Feb 3, 2022
@MobilityData MobilityData deleted a comment from github-actions bot Feb 3, 2022
@MobilityData MobilityData deleted a comment from github-actions bot Feb 3, 2022
@MobilityData MobilityData deleted a comment from github-actions bot Feb 3, 2022
@lionel-nj lionel-nj changed the title fix: Jitpack build build: Jitpack Feb 3, 2022
@lionel-nj lionel-nj linked an issue Feb 3, 2022 that may be closed by this pull request
@lionel-nj lionel-nj self-assigned this Feb 3, 2022
@lionel-nj lionel-nj marked this pull request as ready for review February 3, 2022 22:52
main/build.gradle Outdated Show resolved Hide resolved
main/build.gradle Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 173780c here (report will disappear after 90 days).

Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @lionel-nj!

LGTM, looking at the log seems like it's finding the tasks and building ok now:
https://jitpack.io/com/github/MobilityData/gtfs-validator/f0e41dd/build.log

@lionel-nj lionel-nj merged commit 33c3b07 into master Feb 9, 2022
@lionel-nj lionel-nj deleted the build/jitpack branch February 9, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project fails to build on jitpack since v3.0.0
2 participants