fix: Upgrade to Guava 31 and use ImmutableMap.Builder.buildOrThrow() instead of build()
#1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImmutableMap.Builder.build() throws if the same key was added to the builder twice. There were thousands of bugs because many people are not aware of that. The `build()` method is deprecated in Guava 31 and replaced by `buildOrThrow()` with the same behaviour. See also: google/guava@4b9c269
aababilov
changed the title
ImmutableMap.Builder.buildOrThrow() instead of build()ImmutableMap.Builder.buildOrThrow() instead of build()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImmutableMap.Builder.build()throws if the same key was added to the builder twice. There were thousands of bugs because many people are not aware of that. Thebuild()method is deprecated in Guava 31 and replaced bybuildOrThrow()with the same behaviour.See also: google/guava@4b9c269