Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates scripts to modify mobilitydatabase.org to old.mobilitydatabase.org #1108

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

maximearmstrong
Copy link
Contributor

Summary:

The Mobility Database is now hosted on old.mobilitydatabase.org as we are moving to a new solution in the upcoming months. Since the acceptance tests are leveraging the Mobility Database, the scripts using the URL had to be updated.

Expected behavior:

Same as before.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@maximearmstrong maximearmstrong added the enhancement New feature request or improvement on an existing feature label Feb 15, 2022
@maximearmstrong maximearmstrong self-assigned this Feb 15, 2022
@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 2d4ef06 here (report will disappear after 90 days).

Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are URLs that need to change similarly in the README.md and ACCEPTANCE_TESTS.md files too.

@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 2fb5b05 here (report will disappear after 90 days).

Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I updated the link in the pinned issue and release note.
Thanks Maxime

@maximearmstrong maximearmstrong merged commit 27ad1fb into master Feb 17, 2022
@maximearmstrong maximearmstrong deleted the issue/1107/update-old-mobilitydatabase-org branch February 17, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants