Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SystemStubs test dependency #1140

Merged
merged 1 commit into from
May 11, 2022
Merged

fix: SystemStubs test dependency #1140

merged 1 commit into from
May 11, 2022

Conversation

maximearmstrong
Copy link
Contributor

Summary:

This PR:

  • removes System Lambda from build.gradle
  • updates the implementation of SystemStubs to be a testImplementation
  • updates the version of SystemStubs

Expected behavior:

Same as before, but the dependency to SystemStubs won't be packaged in the JAR file.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@maximearmstrong maximearmstrong self-assigned this May 11, 2022
@maximearmstrong maximearmstrong added this to In Review in The Tech Dashboard (archived) via automation May 11, 2022
@maximearmstrong maximearmstrong marked this pull request as ready for review May 11, 2022 19:43
@maximearmstrong maximearmstrong mentioned this pull request May 11, 2022
Merged
barbeau
barbeau approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maximearmstrong!

The Tech Dashboard (archived) automation moved this from In Review to Approved May 11, 2022
@barbeau
Copy link
Member

barbeau commented May 11, 2022

Hmmm...some checks are failing - maybe try re-running them?

@maximearmstrong
Copy link
Contributor Author

Hmmm...some checks are failing - maybe try re-running them?

Yes, for some reason the checks sometimes fail to find com.github.sherter.google-java-format, but succeed when re-run.

@maximearmstrong maximearmstrong merged commit a5a68f5 into master May 11, 2022
The Tech Dashboard (archived) automation moved this from Approved to Done May 11, 2022
@maximearmstrong maximearmstrong deleted the test-dependendy-system-stubs branch May 11, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbeau barbeau barbeau approved these changes

Assignees

@maximearmstrong maximearmstrong

Labels
None yet
Projects
No open projects
The Tech Dashboard (archived)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maximearmstrong @barbeau