Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docker Image push to GitHub Container Registry #1142

Merged
merged 2 commits into from
May 11, 2022

Conversation

maximearmstrong
Copy link
Contributor

Fixes #1105 : Docker builds are failing

This PR replaces the Personal Access Token (PAT) used in the docker.yml workflow with a GitHub Token. According to GitHub, PATs used to authenticate to ghcr.io should be avoided.

Along with the changes made in this PR, the steps shown here were followed so that the package could access the GitHub token.

Expected behavior:

The Docker Image push to GitHub Container Registry should work properly.

Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@maximearmstrong maximearmstrong self-assigned this May 11, 2022
@maximearmstrong maximearmstrong added this to In Review in The Tech Dashboard (archived) via automation May 11, 2022
@maximearmstrong maximearmstrong marked this pull request as ready for review May 11, 2022 21:03
Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maximearmstrong! We can confirm this works after merge to main branch.

The Tech Dashboard (archived) automation moved this from In Review to Approved May 11, 2022
@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 35dfcd1 here (report will disappear after 90 days).

@maximearmstrong maximearmstrong merged commit 086b5a4 into master May 11, 2022
The Tech Dashboard (archived) automation moved this from Approved to Done May 11, 2022
@maximearmstrong maximearmstrong deleted the issue/1105/docker-image-push-fail branch May 11, 2022 22:00
@maximearmstrong
Copy link
Contributor Author

Thanks @maximearmstrong! We can confirm this works after merge to main branch.

It worked! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Docker builds are failing
2 participants