-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recommended file notice #1151
feat: recommended file notice #1151
Conversation
9a249fc
to
90818c5
Compare
@KClough could you remove the mention of |
Updated! |
6e16db5
to
5179c0a
Compare
1740012
to
03c38bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment aside, we are ready to merge this PR. Thank you @KClough!
@@ -0,0 +1,31 @@ | |||
/* | |||
* Copyright 2020 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add your organization to the copyright if you'd like and also update the year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change it, you can add [acceptance test skip]
at the end of your commit message so the acceptance tests don't run once again.
Actually, if possible, the modifications applied to |
3eab428
to
febfe9f
Compare
I didn't add the update to the Rules file in this PR because the Rule isn't actually applied to any datasets yet. Please confirm if you still think it makes sense to be in this PR. |
I think it's ok because it is partially mostly related to As per the copyright, I believe it should be |
febfe9f
to
8f36a17
Compare
Thank you @KClough! |
Summary:
Related #877
Adds a new annotation for recommended files and applies this annotation to
feed_info.txt
andshapes.txt
Expected behavior:
A new validator warning is generated when either
feed_info.txt
is missingPlease make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything@isabelle-dr per your request, this pull request contains just the notice.