Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update acceptance_test.yml to reflect new -cli.jar naming. #1168

Merged
merged 11 commits into from
May 25, 2022

Commits on May 14, 2022

  1. Per issue MobilityData#1139, refactor how versions are handled in pro…

    …ject.
    
    Currently, project version info is passed in via a `versionTag` env variable,
    which is only specified in the Github workflow environment.  Consequently,
    `project.version` ends up being `null` when run locally.  This causes
    weirdness for tools that expect a valid version number.
    
    This change switches the project to use the axion-release plugin, which
    determines the project version by looking at the git repo's tags.
    
    Along with that switch, I've moved the project group and version
    specification into the root build.gradle allprojects {} such that
    these values do not need to be specified in each sub-poject.
    
    I also did some related clean-up for our jitpack configuration (and
    Maven repository modules, should we every decide to publish them).
    I believe our current jitpack config doesn't actually work correctly
    because we only publish artifacts from the main package, but not core.
    
    You can see this in practice when looking at:
    https://jitpack.io/com/github/MobilityData/gtfs-validator/3.0.1/gtfs-validator-3.0.1.pom
    
    Notice how it has a dependency on the `core` module but we don't
    actually publish it anywhere.  If you actually attempt to use our
    project as a jitpack dependency, it will fail.
    
    The change was to also publish the core module and to specify more
    natural artifact names.
    bdferris-v2 committed May 14, 2022
    Configuration menu
    Copy the full SHA
    eafe498 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Remove references to versionTag env variable in workflows. It is no

    longer needed now that project version is determined within Gradle
    directly.
    
    Also fixup references to shadow jars, since they no longer include
    the versionTag in the filename (also _cli => -cli).
    bdferris-v2 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    9e17ab3 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Restore versionTag behavior for master branch.

    We can't update this code until the PR actually goes in on the master
    branch.
    bdferris-v2 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    c53da0d View commit details
    Browse the repository at this point in the history
  2. Fix typo in yml.

    bdferris-v2 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    f82ca27 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44a4bd8 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2022

  1. Remove all references to versionTag from docker.yml

    I also cleaned up some other variables from the docker config that don't seem to be used.
    bdferris-v2 committed May 22, 2022
    Configuration menu
    Copy the full SHA
    8ade38c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d65691d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Configuration menu
    Copy the full SHA
    2d4c313 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Configuration menu
    Copy the full SHA
    74b4d70 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Configuration menu
    Copy the full SHA
    149a224 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0188efe View commit details
    Browse the repository at this point in the history