-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Check for new version of app during validation #1176
feat: Check for new version of app during validation #1176
Conversation
…ion is available.
main/src/main/java/org/mobilitydata/gtfsvalidator/util/VersionResolver.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bdferris-v2, this is great. I left some questions and suggestions in-line.
Also, did you create the wiki page manually @bdferris-v2 ? I'm mainly asking to know if we will have to update the version manually or is that part of the process?
app/gui/src/main/java/org/mobilitydata/gtfsvalidator/app/gui/GtfsValidatorApp.java
Outdated
Show resolved
Hide resolved
app/gui/src/main/java/org/mobilitydata/gtfsvalidator/app/gui/ValidationDisplay.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/report/HtmlReportGenerator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/ReportSummary.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/report/HtmlReportGenerator.java
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/VersionResolver.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/util/VersionResolver.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/util/VersionInfoTest.java
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/util/VersionResolverTest.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
Outdated
Show resolved
Hide resolved
@maximearmstrong to answer your original question, I just created the wiki page manually. I believe we would also update it manually as needed. It would probably get its own step in the Release instructions. |
Just to bump this: any remaining concerns? |
It looks like all the comments from @maximearmstrong and @barbeau were addressed. Since he is off today, I will go ahead and merge this PR. This way, it can be included in the release :). Thank you @bdferris for this great addition to the app! |
Summary:
Adds functionality to to compare the current app version against the latest release version (per this wiki page).
Closes #1171
Expected behavior:
When a new version of the app is available, show notices in the validation report and the gui application.
gradle test
to make sure you didn't break anything