Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check for new version of app during validation #1176

Merged

Conversation

bdferris-v2
Copy link
Collaborator

Summary:

Adds functionality to to compare the current app version against the latest release version (per this wiki page).

Closes #1171

Expected behavior:

When a new version of the app is available, show notices in the validation report and the gui application.

Screen Shot 2022-05-30 at 9 24 15 PM

Screen Shot 2022-05-30 at 9 23 51 PM

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@maximearmstrong maximearmstrong added this to In Review in The Tech Dashboard (archived) via automation May 31, 2022
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdferris-v2, this is great. I left some questions and suggestions in-line.

Also, did you create the wiki page manually @bdferris-v2 ? I'm mainly asking to know if we will have to update the version manually or is that part of the process?

The Tech Dashboard (archived) automation moved this from In Review to Pending approval May 31, 2022
@bdferris-v2
Copy link
Collaborator Author

@maximearmstrong to answer your original question, I just created the wiki page manually. I believe we would also update it manually as needed. It would probably get its own step in the Release instructions.

@bdferris-v2
Copy link
Collaborator Author

Just to bump this: any remaining concerns?

@isabelle-dr
Copy link
Contributor

isabelle-dr commented Jun 3, 2022

It looks like all the comments from @maximearmstrong and @barbeau were addressed. Since he is off today, I will go ahead and merge this PR. This way, it can be included in the release :).

Thank you @bdferris for this great addition to the app!

@isabelle-dr isabelle-dr merged commit cec914e into MobilityData:master Jun 3, 2022
The Tech Dashboard (archived) automation moved this from Pending approval to Done Jun 3, 2022
@bdferris-v2 bdferris-v2 deleted the issue/1171/version_check branch October 7, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Check for new version of app during validation
4 participants