Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes titles in RULES.md #1177

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

maximearmstrong
Copy link
Contributor

Summary:

This PR fixes 2 titles that were incorrectly displayed in RULES.md. In both cases, the problem was caused by the absence of between a tag and the title, for example:

</details>
# System errors

should be

</details>

# System errors

Expected behavior:

Same as before with properly formatted titles.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@maximearmstrong maximearmstrong self-assigned this Jun 1, 2022
@maximearmstrong maximearmstrong added this to In Review in The Tech Dashboard (archived) via automation Jun 1, 2022
@maximearmstrong maximearmstrong marked this pull request as ready for review June 1, 2022 17:58
Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maximearmstrong !

The Tech Dashboard (archived) automation moved this from In Review to Approved Jun 1, 2022
@maximearmstrong maximearmstrong merged commit 187be96 into master Jun 1, 2022
@maximearmstrong maximearmstrong deleted the fix-titles-in-rules-md branch June 1, 2022 18:48
The Tech Dashboard (archived) automation moved this from Approved to Done Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants