feat: Add unit-tests for @PrimaryKey and @FirstKey/@SequenceKey #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvechnikov2
approved these changes
Jul 14, 2022
core/src/main/java/org/mobilitydata/gtfsvalidator/testing/LoadingHelper.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/testing/LoadingHelper.java
Show resolved
Hide resolved
|
Hey @maximearmstrong, Artur has given this an LGTM but due to some issues with his work computer + GitHub account, he had to reset his account and lost review privileges. Any chance you can give this an approval while that's being sorted out? |
maximearmstrong
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for multi-colum primary key refactoring to come in support of #1187, this PR adds unit-tests for @PrimaryKey and @FirstKey/@SequenceKey
gradle testto make sure you didn't break anything